Various unclosed Zip-Streams. Ticket for each?

[Fabian Lange <fa...@codecentric.de>]

Hi all,
I spent some time browsing through the usage of zip/jar input and
outpoutstreams.
I noticed that in the codebase often the source of the zip inpustream is
closed, but not the zipinputstream itself. this leads to leaking native
memory (as the inflater is open which holds on native memory)

I have attached a diff of my changes.

Shall I do issues for each or can somebody with enough powers maybe apply
them directly?

Fabian


--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz

Re: Various unclosed Zip-Streams. Ticket for each?

[Carsten Ziegeler <cz...@apache.org>]

Hi,

thanks for taking care of this. I think it's best if you could create
separate issues for each project. We need to track the changes through jira.

Regards
Carsten

Fabian Lange wrote
> Hi all,
> I spent some time browsing through the usage of zip/jar input and
> outpoutstreams.
> I noticed that in the codebase often the source of the zip inpustream is
> closed, but not the zipinputstream itself. this leads to leaking native
> memory (as the inflater is open which holds on native memory)
> 
> I have attached a diff of my changes.
> 
> Shall I do issues for each or can somebody with enough powers maybe
> apply them directly?
> 
> Fabian
> 
> 
> --
> Fabian Lange | Performance Expert
> mobil: +49 (0) 160.3673393
> 
> codecentric AG | Hochstrae 11 | 42697 Solingen | Deutschland
> 
> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
> Vorstand: Michael Hochgrtel . Mirko Novakovic . Rainer Vehns
> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jger . Jrgen Schtz


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org