You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Anshul-creator (via GitHub)" <gi...@apache.org> on 2025/11/21 23:09:04 UTC
[PR] Fix: Stabilize `ReferenceConfigTest` by Disabling Metrics Initialization and Ensuring Test Isolation [dubbo]
Anshul-creator opened a new pull request, #15787:
URL: https://github.com/apache/dubbo/pull/15787
## What is the purpose of the change?
This PR stabilizes all `ReferenceConfig` tests that were intermittently failing under randomized execution orders (NonDex):
- `testCreateInvokerForLocalRefer`
- `testClassLoader`
- `testMultipleRegistryForRemoteRefer`
- `testCreateInvokerForRemoteRefer`
- `testCreateInvokerWithRemoteUrlForRemoteRefer`
- `testCreateInvokerWithRegistryUrlForRemoteRefer`
- `testGenericAndInterfaceConflicts`
- `testDifferentClassLoader`
- `testAppendConfig`
- `test1ReferenceRetry`
- `test2ReferenceRetry`
All of these tests were affected by nondeterministic behavior triggered by Micrometer’s composite meter registry during Dubbo bootstrap, even though the tests do not depend on metrics.
## Root Cause
When `ReferenceConfig.init()` invokes `DubboBootstrap.initialize()`, Dubbo initializes the metrics subsystem. This leads Micrometer’s `CompositeMeterRegistry` to iterate through an internal `IdentityHashMap`, whose iteration order is non-deterministic.
Under certain NonDex randomized execution orders, this results in exceptions such as:
```lua
java.lang.ArrayIndexOutOfBoundsException
at java.util.IdentityHashMap$KeyIterator.next(...)
at io.micrometer.core.instrument.composite.CompositeMeterRegistry.updateDescendants(...)
```
These failures occur before any reference-related logic runs, making them completely unrelated to test intent. The ReferenceConfig do not require metrics to be enabled. Thus, automatic metrics initialization was introducing avoidable nondeterminism failures.
## Changes Made
- Disabled the metrics subsystem at the beginning of each test
- Cleared all system properties using `SysProps.clear()` in both `@BeforeEach` and `@AfterEach`.
- Ensured consistent test isolation by resetting framework state
## Verification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
```bash
./mvnw -q -pl dubbo-config/dubbo-config-api \
edu.illinois:nondex-maven-plugin:2.2.1:nondex \
-DnondexRuns=20
```
The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the `dubbo-config/dubbo-config-api/.nondex` directory.
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix: Stabilize `ReferenceConfigTest` by Disabling Metrics Initialization and Ensuring Test Isolation [dubbo]
Posted by "RainYuY (via GitHub)" <gi...@apache.org>.
RainYuY merged PR #15787:
URL: https://github.com/apache/dubbo/pull/15787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix: Stabilize `ReferenceConfigTest` by Disabling Metrics Initialization and Ensuring Test Isolation [dubbo]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15787:
URL: https://github.com/apache/dubbo/pull/15787#issuecomment-3564990940
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/15787?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 32.05%. Comparing base ([`9b32dc1`](https://app.codecov.io/gh/apache/dubbo/commit/9b32dc11eb3f2bd080f2b6e87591caba2ece0468?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c878fd6`](https://app.codecov.io/gh/apache/dubbo/commit/c878fd6bae0f98422dbfb68ceabd2722debefe9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (9b32dc1) and HEAD (c878fd6). Click for more details.
>
> <details><summary>HEAD has 7 uploads less than BASE</summary>
>
>| Flag | BASE (9b32dc1) | HEAD (c878fd6) |
>|------|------|------|
>|integration-tests-java8|1|0|
>|integration-tests-java21|1|0|
>|unit-tests-java25|1|0|
>|unit-tests-java11|1|0|
>|unit-tests-java21|1|0|
>|unit-tests-java17|1|0|
>|unit-tests-java8|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.3 #15787 +/- ##
=============================================
- Coverage 60.76% 32.05% -28.72%
+ Complexity 11698 10113 -1585
=============================================
Files 1938 1937 -1
Lines 88646 88624 -22
Branches 13379 13295 -84
=============================================
- Hits 53868 28409 -25459
- Misses 29250 56065 +26815
+ Partials 5528 4150 -1378
```
| [Flag](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [samples-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.02% <ø> (-0.04%)` | :arrow_down: |
| [samples-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.58% <ø> (-0.12%)` | :arrow_down: |
| [unit-tests-java11](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java17](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java25](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15787/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/15787?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org