[GitHub] [carbondata] QiangCai commented on a change in pull request #3849: [CARBONDATA-3913] Table level timestampformat support

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #3849:
URL: https://github.com/apache/carbondata/pull/3849#discussion_r457429601



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala
##########
@@ -122,6 +122,35 @@ class TestLoadDataWithDiffTimestampFormat extends QueryTest with BeforeAndAfterA
 
   }
 
+  test("test load data with timestamp format set at different levels") {
+    sql("DROP TABLE IF EXISTS t3")
+    sql(
+      """
+           CREATE TABLE IF NOT EXISTS t3
+           (ID Int, date date, starttime Timestamp, country String,
+           name String, phonetype String, serialname String, salary Int)
+           STORED AS carbondata TBLPROPERTIES('table_timestampformat'='yyyy-MM-dd')

Review comment:
       please add test case for "describe formatted table" and verify the table property list that should contain new properties.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org