You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/16 08:09:13 UTC
[GitHub] [incubator-hudi] bvaradar opened a new pull request #1636: [HUDI-895] Remove unnecessary listing .hoodie folder when using timeline server
bvaradar opened a new pull request #1636:
URL: https://github.com/apache/incubator-hudi/pull/1636
Found this during rollout testing. With embedded timeline server, executor task makes one additional listing of .hoodie folder per task which is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar merged pull request #1636: [HUDI-895] Remove unnecessary listing .hoodie folder when using timeline server
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1636:
URL: https://github.com/apache/incubator-hudi/pull/1636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io commented on pull request #1636: [HUDI-895] Remove unnecessary listing .hoodie folder when using timeline server
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1636:
URL: https://github.com/apache/incubator-hudi/pull/1636#issuecomment-629611183
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=h1) Report
> Merging [#1636](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/25e0b75b3d03b6d460dc18d1a5fce7b881b0e019&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1636 +/- ##
============================================
+ Coverage 71.81% 71.92% +0.11%
- Complexity 1092 1094 +2
============================================
Files 386 386
Lines 16608 16610 +2
Branches 1667 1667
============================================
+ Hits 11927 11947 +20
+ Misses 3955 3940 -15
+ Partials 726 723 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../hudi/common/table/view/FileSystemViewManager.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdNYW5hZ2VyLmphdmE=) | `81.03% <82.35%> (+1.72%)` | `7.00 <5.00> (+1.00)` | |
| [...java/org/apache/hudi/client/HoodieWriteClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVdyaXRlQ2xpZW50LmphdmE=) | `72.51% <100.00%> (-0.39%)` | `12.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `83.46% <100.00%> (ø)` | `22.00 <2.00> (ø)` | |
| [.../org/apache/hudi/utilities/sources/InputBatch.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSW5wdXRCYXRjaC5qYXZh) | `95.00% <0.00%> (-5.00%)` | `7.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...apache/hudi/common/util/collection/RocksDBDAO.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9Sb2Nrc0RCREFPLmphdmE=) | `75.41% <0.00%> (+0.55%)` | `0.00% <0.00%> (ø%)` | |
| [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `92.48% <0.00%> (+2.34%)` | `0.00% <0.00%> (ø%)` | |
| [...on/table/view/RemoteHoodieTableFileSystemView.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvUmVtb3RlSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `81.96% <0.00%> (+4.37%)` | `0.00% <0.00%> (ø%)` | |
| [...a/org/apache/hudi/common/util/ValidationUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvVmFsaWRhdGlvblV0aWxzLmphdmE=) | `61.53% <0.00%> (+15.38%)` | `4.00% <0.00%> (ø%)` | |
| [...g/apache/hudi/exception/HoodieRemoteException.java](https://codecov.io/gh/apache/incubator-hudi/pull/1636/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVJlbW90ZUV4Y2VwdGlvbi5qYXZh) | `100.00% <0.00%> (+100.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=footer). Last update [25e0b75...bdb3ea4](https://codecov.io/gh/apache/incubator-hudi/pull/1636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org