You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "geniusjoe (via GitHub)" <gi...@apache.org> on 2024/09/03 17:47:41 UTC

[PR] [Issue 1276][consumer] stop timer when close timedAckGroupingTracker [pulsar-client-go]

geniusjoe opened a new pull request, #1279:
URL: https://github.com/apache/pulsar-client-go/pull/1279

   
   ### Contribution Checklist
   
   Fixes #1262
   
   ### Motivation
   
   According to #1262 
   
   > The ticker.Stop method is never called on the timedAckGroupingTracker member ticker, and so it is leaked.
   
   ### Modifications
   
   Call `t.ticker.Stop()` function when close `timedAckGroupingTracker`.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
     - *Added integration tests*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Issue 1262][consumer] stop timer when close timedAckGroupingTracker [pulsar-client-go]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #1279:
URL: https://github.com/apache/pulsar-client-go/pull/1279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org