[GitHub] [kafka] dajac commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1098623901


##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel,
           }
         }
         // Finally, the idToName map contains all the topics that we are authorized to delete.
-        // Perform the deletion and create responses for each one.
-        controller.deleteTopics(context, idToName.keySet).thenApply { idToError =>
-          idToError.forEach { (id, error) =>
-            appendResponse(idToName.get(id), id, error)
+        // First check the controller mutation quota if necessary, and then

Review Comment:
   The quota is basically a `Sensor` which would only be updated by the QuorumController thread. However, I suppose that the internal metric lock is also acquired when the metric is reported so the QuorumController would not be the only one trying to acquire it, I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org