You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "Matthias Friedrich (JIRA)" <ji...@apache.org> on 2012/07/12 20:37:34 UTC
[jira] [Created] (CRUNCH-17) Split unit tests from integration
tests
Matthias Friedrich created CRUNCH-17:
----------------------------------------
Summary: Split unit tests from integration tests
Key: CRUNCH-17
URL: https://issues.apache.org/jira/browse/CRUNCH-17
Project: Crunch
Issue Type: Task
Components: Core
Reporter: Matthias Friedrich
Assignee: Matthias Friedrich
Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-17:
-------------------------------------
Attachment: 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz
Two nasty mass renaming patches coming up. I don't feel overly confident with the second one but it seemed to work.
Thanks for your help guys!
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Rahul Sharma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413516#comment-13413516 ]
Rahul Sharma commented on CRUNCH-17:
------------------------------------
Alternatively you can add a test sources folder for Integration tests eg. src/integration-test/java, kind of location using the build-helper-plugin. Then in eclipse you can only build the src/test/java folder, that way you would be able to run all unit tests.
You will be required to have a convention for tests in this location such as ending in *IT* else maven will execute them in test phase. After that we can configure failsafe plugin to execute them in integration-phase.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413586#comment-13413586 ]
Josh Wills commented on CRUNCH-17:
----------------------------------
Interesting: https://issues.sonatype.org/browse/MNGECLIPSE-2387
Matthias, does changing the lifecycle phase to "validate" as suggested in that ticket solve the eclipse integration problem? If so, that seems like the best solution.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413352#comment-13413352 ]
Josh Wills commented on CRUNCH-17:
----------------------------------
Is the idea to be able to launch all of the unit tests from the IDE? I rarely do that; I'm usually running one test at a time when I'm in the IDE and use maven from the commandline to run the entire suite of tests. But maybe I'm unusual in this regard.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417143#comment-13417143 ]
Tom White commented on CRUNCH-17:
---------------------------------
> I would *really* like it if the full test suite would run more quickly, but that's another story (which might involve using the MemPipeline a lot more in the automated tests).
I was thinking that this could be done by parameterizing the test suite so that you could run the tests i) in-memory, ii) using MR-pipeline, or iii) both. This would be controllable via a command line switch (e.g. a system property), and could be implemented using http://junit.sourceforge.net/javadoc/org/junit/runners/Parameterized.html.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Fix For: 0.3.0
>
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Wills resolved CRUNCH-17.
------------------------------
Resolution: Fixed
Fix Version/s: 0.3.0
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Fix For: 0.3.0
>
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413085#comment-13413085 ]
Matthias Friedrich commented on CRUNCH-17:
------------------------------------------
After some research it seems there's still no perfect solution with Maven/JUnit/Eclipse. Just renaming the slow tests from *Test to *IT and using the Maven Failsafe Plugin to execute them during the integration-test phase isn't enough. You'd still need a way to keep them apart in the IDE without having to build test suites manually. I'm leaning towards the solution we use at work: Move the integration tests out of the way into a separate Maven module, rename them and run them via the Failsafe Plugin.
Thoughts?
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414043#comment-13414043 ]
Josh Wills commented on CRUNCH-17:
----------------------------------
Ack, nm-- my local copy wasn't sync'd. Fixing it now. :)
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414461#comment-13414461 ]
Josh Wills commented on CRUNCH-17:
----------------------------------
I got it worked out and committed the patches. ;-) Thanks Matthias!
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Rahul Sharma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413527#comment-13413527 ]
Rahul Sharma commented on CRUNCH-17:
------------------------------------
Must be a bug in maven eclipse plugin. I tried with M2eclipse and it picked up the right configuration. Rest I think the config can work as expected, even if few extra clicks are required as that would be a one time task.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413606#comment-13413606 ]
Matthias Friedrich commented on CRUNCH-17:
------------------------------------------
Yes, it works with "validate". Thanks Josh!
I'll submit a patch later today.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413512#comment-13413512 ]
Matthias Friedrich commented on CRUNCH-17:
------------------------------------------
Most developers I've worked with run the entire test suite from the IDE and only use Maven once before they commit. I've seen people from the TDD crowd run the test suite every couple of minutes. Some also like up to the minute accurate test coverage reports via EclEmma.
In my opinion, right now the test suite is a hurdle for new contributors. Just being able to run the examples requires running the test suite (unless you know the right Maven switch) and that takes 25 minutes (!) on my office machine. On my home notebook (centrino 2, but with a slow disk) I guess it would be a lot longer if it actually succeeded. Like with Hadoop, you can't contribute unless you've got a fast developer workstation available.
So, what do you want me to do? I could start without the separate Maven module and then we re-evaluate?
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414397#comment-13414397 ]
Matthias Friedrich commented on CRUNCH-17:
------------------------------------------
Hmm, I just noticed that the patch doesn't apply cleanly using "git am" because of line ending issues. It seems the test resources contain CRLF line endings which is discouraged in git (or so I've read, I'm a git newbie). I managed to apply it using "git am --keep-cr", but best thing would be to convert the test data in the respository to unix line endings.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Gabriel Reid (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413494#comment-13413494 ]
Gabriel Reid commented on CRUNCH-17:
------------------------------------
I also rarely launch all of the automated tests from Eclipse -- however, that's due to how long it takes to run the automated tests in Eclipse. On projects where the automated testing can run quickly (i.e. less than 20 seconds), I run the full test suite constantly from my IDE.
My typical workflow with Crunch is running a single test class while developing on the code that it covers, and then running the full test suite before I commit. I would *really* like it if the full test suite would run more quickly, but that's another story (which might involve using the MemPipeline a lot more in the automated tests).
I'm actually ok if the unit tests can be run separately only via maven (and not directly from the IDE) -- I think that this would already be an improvement in that it would facilitate running more tests more regularly. Having the tests split up to allow running only the unit tests in the IDE is less important to me personally.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413524#comment-13413524 ]
Matthias Friedrich commented on CRUNCH-17:
------------------------------------------
@Rahul: I tried that, too, but noticed one problem. mvn eclipse:eclipse doesn't pick up test source directories so you have to add them to Eclipse's build path manually. Source directories work, so it's probably a bug.
If everyone is ok with bending Maven conventions a little and a few extra clicks in Eclipse then we should do it, IMHO.
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-17) Split unit tests from integration
tests
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414040#comment-13414040 ]
Josh Wills commented on CRUNCH-17:
----------------------------------
Not at all-- thank you.
I'm in the process of applying the first patch and ran into some problems-- there is a StringWrapper class that is being used in SortIT that I'm not finding. Did you forget to add it to the patch?
> Split unit tests from integration tests
> ---------------------------------------
>
> Key: CRUNCH-17
> URL: https://issues.apache.org/jira/browse/CRUNCH-17
> Project: Crunch
> Issue Type: Task
> Components: Core
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Labels: maven
> Attachments: 0001-CRUNCH-17-Split-unit-from-integration-tests.patch.gz, 0002-CRUNCH-17-Scrunch-test-reorganization.patch.gz
>
>
> Currently, the test suite is a mix of fast unit tests and slow integration tests which prevents developers from executing tests early and often. It should be possible to run unit tests separately via Eclipse (or some other IDE) and Maven. Integration tests should run in Maven's integration-test phase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira