[jira] Commented: (CASSANDRA-627) use FastDateFormat instead of SimpleDateFormat

["gabriele renzi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789178#action_12789178 ] 

gabriele renzi commented on CASSANDRA-627:
------------------------------------------

I split the patch in two, as I believe one deserves inclusion while the other may be irreleveant. 
Also, all tests pass, but I have the feeling there should be a TimeZone and a Locale in the instantiation of DateFormat objects.

> use FastDateFormat instead of SimpleDateFormat 
> -----------------------------------------------
>
>                 Key: CASSANDRA-627
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-627
>             Project: Cassandra
>          Issue Type: Improvement
>         Environment: all
>            Reporter: gabriele renzi
>            Priority: Minor
>         Attachments: CASSANDRA-627-1.patch, CASSANDRA-627-2.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> FastDateFormat is thread safe and can be shared by different instances so we can avoid the overhead of recreating it every time. 
> As in LogUtil we only rely on it for formatting it is a good fit. 
> The usage in Circuit is already protected by a lock so probably no real need for this change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.