You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2017/09/15 03:50:39 UTC
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Bharath Vissapragada has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8079
Change subject: Change log for 2.10.0 release
......................................................................
Change log for 2.10.0 release
Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
---
A docs/changelog-2.10.html
M impala-docs.html
2 files changed, 590 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/8079/1
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has submitted this change and it was merged.
Change subject: Change log for 2.10.0 release
......................................................................
Change log for 2.10.0 release
Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Reviewed-on: http://gerrit.cloudera.org:8080/8079
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Bharath Vissapragada <bh...@cloudera.com>
---
A docs/changelog-2.10.html
M impala-docs.html
2 files changed, 590 insertions(+), 6 deletions(-)
Approvals:
Bharath Vissapragada: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148:
Hey Bharath, just a note, it's OK to keep this around until the next release's docs are available. That means at least some version's HTML docs are linked on the docs page. RIght now, there's nothing.
I updated https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:10:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148:
> Hey Bharath, just a note, it's OK to keep this around until the next releas
Okay. Should we version the contents of that html directory and retain older docs too? (Copying stuff to docs/build/html/<release>/* and always symlink the latest to docs/build/html/latest/*)
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:28:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148:
> Okay. Should we version the contents of that html directory and retain olde
John had requested we maintain the "latest" in HTML and the archived in PDF only.
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:31:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148:
> Just curious, any particular reason? (Apart from the Google search presenti
I think it was just that, but this chat was from a long time ago. I realize there are other ways to get around that.
...
On a personal note, I like that when the docs get updated in place, you get a clean diff that highlights the changes, like this:
https://gerrit.cloudera.org/#/c/7397/
It would be nice to retain such a diff even if we decide to do what you propose, and I would request we have workflows in place so that we get to see that. It's too easy to end up with cases where there is a lot of left-side pink and right-side green, making it harder to spot meaningful differences.
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:56:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )
Change subject: Change log for 2.10.0 release
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:
http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148:
> John had requested we maintain the "latest" in HTML and the archived in PDF
Just curious, any particular reason? (Apart from the Google search presenting older versions)
--
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:45:50 +0000
Gerrit-HasComments: Yes