You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/02/28 19:19:00 UTC
[GitHub] [nifi] markap14 commented on pull request #5765: NIFI-9543: Add bring-to-front functionality to labels
markap14 commented on pull request #5765:
URL: https://github.com/apache/nifi/pull/5765#issuecomment-1054582005
Thanks @mcgilman . I haven't had a chance to completely review/test this yet. One thing that I think we need to address, though, is something that I just noticed the other day with the 'retry' fields that were recently added. I had to make a small update: https://github.com/apache/nifi/pull/5809/files#diff-fcc9a36983c80e3ddfb13c77ac2db46d83346e6f55f84f44cedfc7a33bf43e02R67-R177
The issue here was related to the fact that we add a new field to a component. So in this case, zIndex is added to label. If you've pushed your flow to Registry using 1.15.3 or earlier, and now you startup with this version, we end up seeing a "Local Change" to each of those labels. And you can't revert the change. As a result, you won't be able to change to a later version. So we need to make a similar update here: If there's a flow difference that changes the zIndex from `null` to the default value (`0`), then we need to return `true` from that `isEnvironmentalChange` method. Granted, `isEnvironmentalChange` is probably no longer the most accurate name for that method, but basically is used to filter out any flow change that we don't want to consider a "Local Modification".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org