[GitHub] [bookkeeper] Vanlightly commented on pull request #2868: Readops and writeops for the read cache are disabled after the readcache has been shutdown

[GitBox <gi...@apache.org>]

Vanlightly commented on pull request #2868:
URL: https://github.com/apache/bookkeeper/pull/2868#issuecomment-962000206


   @pradeepbn I am not so keen on this lock being in the hot path for every read. We started at the ReadCache because we saw that specific problem in prod, then moved up but I think what we have seen here is that the shutdown sequence itself needs some love. For example, this particular problem can probably be solved in the BookieServer class by ensuring that the request processor it shutdown first, then ledger storage.
   
   I think we should close this PR and take a deeper look at the shutdown sequence. There is a related issue #2879 that also is related to shutdown.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org