You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/03/16 17:45:01 UTC
svn commit: r1827033 -
/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Author: markt
Date: Fri Mar 16 17:45:00 2018
New Revision: 1827033
URL: http://svn.apache.org/viewvc?rev=1827033&view=rev
Log:
SpotBugs
Avoid NPEs on concurrent calls to stop()
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java?rev=1827033&r1=1827032&r2=1827033&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java Fri Mar 16 17:45:00 2018
@@ -88,9 +88,9 @@ public class TcpPingInterceptor extends
}
@Override
- public void stop(int svc) throws ChannelException {
+ public synchronized void stop(int svc) throws ChannelException {
running = false;
- if ( thread != null ) {
+ if (thread != null) {
thread.interrupt();
thread = null;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org