You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Audrey So (JIRA)" <ji...@apache.org> on 2017/08/17 20:24:01 UTC
[jira] [Comment Edited] (CB-12895) Replace jshint with eslint in
our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131240#comment-16131240 ]
Audrey So edited comment on CB-12895 at 8/17/17 8:23 PM:
---------------------------------------------------------
These are the completed and merged repos -->
Cordova-android
Cordova-browser
Cordova-cli (remove old jshint files)
Cordova-common
Cordova-create
Cordova-ios
Cordova-js
Cordova-lib
Cordova-osx
Cordova-plugin-battery-status
Cordova-plugin-camera
Cordova-plugin-device
Cordova-plugin-dialogs
Cordova-plugin-geolocation
Cordova-plugin-globalization
Cordova-plugin-media-capture (error on Travis?)
Cordova-plugin-network-information
Cordova-plugin-test-framework (remove old jshint files)
Cordova-plugin-vibration (remove old jshint files)
Cordova-plugin-wkwebview-engine
Cordova-plugman
Cordova-serve
Cordova-windows
These are the ones that are left to be merged in & may have some failing CI tests. I can double check -->
cordova-coho
Cordova-fetch
Cordova-plugin-file
cordova-plugin-inappbrowser
Did I miss any repos?
was (Author: auso):
These are the completed repos -->
Cordova-android
Cordova-browser
Cordova-cli (remove old jshint files)
Cordova-common
Cordova-create
Cordova-ios
Cordova-js
Cordova-lib
Cordova-osx
Cordova-plugin-battery-status
Cordova-plugin-camera
Cordova-plugin-device
Cordova-plugin-dialogs
Cordova-plugin-geolocation
Cordova-plugin-globalization
Cordova-plugin-media-capture (error on Travis?)
Cordova-plugin-network-information
Cordova-plugin-test-framework (remove old jshint files)
Cordova-plugin-vibration (remove old jshint files)
Cordova-plugin-wkwebview-engine
Cordova-plugman
Cordova-serve
Cordova-windows
These are the ones that are left to be merged in & may have some failing CI tests. I can double check -->
cordova-coho
Cordova-fetch
Cordova-plugin-file
cordova-plugin-inappbrowser
Did I miss any repos?
> Replace jshint with eslint in our tools + platforms
> ---------------------------------------------------
>
> Key: CB-12895
> URL: https://issues.apache.org/jira/browse/CB-12895
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllComponents
> Reporter: Steve Gill
> Assignee: Audrey So
> Priority: Minor
> Labels: cordova-next
>
> Based on this proposal
> https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308
> JSHint does minimal checks and JSCS has been deprecated in favor of ESLint.
> +
> +I suggest to replace the current style checkers with ESLint. This allows to set much more strict styling rules than at at this moment.
> +
> +I recommend using a popular preset, such as [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). Example configuration:
> +
> +```yaml
> +root: true
> +
> +extends: airbnb-base
> +```
> +
> +Many styling issues could be fixed by simply running:
> +
> +```
> +./node_modules/.bin/eslint --fix .
> +```
> +
> +
> +
> +Optionally the indent could be set to 4 instead of 2, because that's used in the current code base.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org