[GitHub] [syncope] ilgrosso commented on a change in pull request #200: Upgrade WA to 6.3.0

[GitBox <gi...@apache.org>]

ilgrosso commented on a change in pull request #200:
URL: https://github.com/apache/syncope/pull/200#discussion_r449526522



##########
File path: core/am/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/wa/GoogleMfaAuthAccountServiceImpl.java
##########
@@ -88,6 +98,15 @@ public GoogleMfaAuthAccount findAccountBy(final String key) {
         return result;
     }
 
+    @Override
+    public PagedResult<GoogleMfaAuthAccount> countFor(final String owner) {
+        PagedResult<GoogleMfaAuthAccount> result = new PagedResult<>();

Review comment:
       Same as above.

##########
File path: core/am/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/wa/GoogleMfaAuthAccountServiceImpl.java
##########
@@ -70,15 +70,25 @@ public void update(final GoogleMfaAuthAccount acct) {
     }
 
     @Override
-    public GoogleMfaAuthAccount findAccountFor(final String owner) {
-        return logic.findAccountFor(owner);
+    public PagedResult<GoogleMfaAuthAccount> findAccountsFor(final String owner) {

Review comment:
       Why returning a `PagedResult` with page number statically set to `1`? Return `List<GoogleMfaAuthAccount>` instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org