You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by jwagenleitner <gi...@git.apache.org> on 2015/11/02 02:45:42 UTC

[GitHub] incubator-groovy pull request: GROOVY-4847 - Missing GDK rounding ...

GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/incubator-groovy/pull/175

    GROOVY-4847 - Missing GDK rounding (and trunc) methods for BigDecimal

    I tried to address the issues raised by @blackdrag in the original groovy/groovy-core#281 PR.  The `round` methods may be slightly confusing since the `BigDecimal#round(MathContext)` method works on  the entire number, so I tried to call that out in the javadoc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/incubator-groovy GROOVY-4847

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-groovy/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #175
    
----
commit 93d34c407ab992ce17c7e6ca82735e0457701a69
Author: John Wagenleitner <jo...@gmail.com>
Date:   2015-11-01T17:08:33Z

    GROOVY-4847 - Missing GDK rounding (and trunc) methods for BigDecimal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-groovy pull request: GROOVY-4847 - Missing GDK rounding ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-groovy/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---