You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2026/10/14 02:57:13 UTC
[PR] [REL_2_STABLE] Add Apache HAWQ attribution for `gpcontrib/pxf_fdw` [cloudberry]
tuhaihe opened a new pull request, #2124:
URL: https://github.com/apache/cloudberry/pull/2124
Greenplum Database took part of gpcontrib/pxf_fdw from the PXF external table client in Apache HAWQ in 2017, and six of its files still contain HAWQ code. Neither LICENSE nor NOTICE mentioned HAWQ.
List those six files in the Apache License part of the Greenplum section in LICENSE. Add HAWQ's copyright notice to NOTICE, worded the same way as in cloudberry-pxf's NOTICE.
The table shows what fraction of each file's code lines (whitespace normalized) also appear in the HAWQ file:
```
pxf_filter.h 64% src/include/access/pxffilters.h
libchurl.c 60% src/backend/access/external/libchurl.c
pxf_filter.c 50% src/backend/access/external/pxffilters.c
libchurl.h 33% src/include/access/libchurl.h
pxf_fragment.h 30% src/include/access/pxfutils.h
pxf_header.c 26% src/backend/access/external/pxfheaders.c
```
pxf_bridge.c, pxf_bridge.h and pxf_header.h carry the same ASF header but have no lines in common with HAWQ, and LICENSE now says so. pxf_deparse.c and pxf_option.c come from postgres_fdw and file_fdw, and the PostgreSQL section already covers them.
Assisted-by: Claude Code
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Add Apache HAWQ attribution for `gpcontrib/pxf_fdw` [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #2124:
URL: https://github.com/apache/cloudberry/pull/2124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org