You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/07/21 12:58:45 UTC
[GitHub] brooklyn-server pull request #772: Allow equivalent plans when replacing
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/772
Allow equivalent plans when replacing
Needed because our routines sometimes rewrite the plan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server osgi-allow-equivalent-plans
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #772
----
commit 3f4188bfe03e068ddc225fede6585ce923973561
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-07-21T09:10:11Z
record a checksum so that on plan rewrite we don't block reinstallation
with test case that fails without the equivalent plan checks, but works with them
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #772: Allow equivalent plans when replacing
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/772
thanks @geomacy - fixed and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #772: Allow equivalent plans when replacing
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/772
For `testOsgiBundleWithBom` it's just an update needed to the test expectation - there are now more tags than before on the result:
```
"equivalent-plan(A8FA402166F072F19CFE88AEA200B001)",
"equivalent-plan(A74550A5F94D4AD144AC5EB816DE6C45)",
{
"traits": [
...
]
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #772: Allow equivalent plans when replacing
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/772
Follow-up to #746 making it slightly more forgiving when replacing, should fix issues when dealing with complex catalogs/blueprints
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #772: Allow equivalent plans when replacing
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/772
test failure is real, in `CatalogResourceTest`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #772: Allow equivalent plans when replacing
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---