[GitHub] [flink] dmvk commented on a change in pull request #18905: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors

[GitBox <gi...@apache.org>]

dmvk commented on a change in pull request #18905:
URL: https://github.com/apache/flink/pull/18905#discussion_r816815757



##########
File path: flink-connectors/flink-connector-aws-kinesis-firehose/pom.xml
##########
@@ -164,6 +158,33 @@ under the License.
 					</execution>
 				</executions>
 			</plugin>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes>
+									<include>org.apache.flink:flink-connector-base</include>
+									<include>org.apache.flink:flink-connector-aws-base</include>
+								</includes>
+							</artifactSet>
+							<relocations>
+								<relocation>
+									<pattern>org.apache.flink.connector.base</pattern>
+									<shadedPattern>org.apache.flink.connector.firehose.shaded.org.apache.flink.connector.base</shadedPattern>

Review comment:
       ```suggestion
   									<shadedPattern>${shade.pattern}.org.apache.flink.connector.base</shadedPattern>
   ```
   It would be nice to have shade pattern as a variable, to make sure it's aligned if we're shading more  than one dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org