You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/30 15:06:38 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #2448: stm32/stm32h7: fix the configuration of PWM outputs when subsequent channels are not enabled
raiden00pl opened a new pull request #2448:
URL: https://github.com/apache/incubator-nuttx/pull/2448
## Summary
The previous implementation didn't work properly when subsequent channels were not enabled (eg. CH1 and CH2 disabled, CH3 enabled).
## Impact
stm32 and stm32h7 only.
## Testing
nucleo-f103rb/pwm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] diegoherranz commented on pull request #2448: stm32/stm32h7: fix the configuration of PWM outputs when subsequent channels are not enabled
Posted by GitBox <gi...@apache.org>.
diegoherranz commented on pull request #2448:
URL: https://github.com/apache/incubator-nuttx/pull/2448#issuecomment-736774177
Thanks for the explanation (and the fix).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #2448: stm32/stm32h7: fix the configuration of PWM outputs when subsequent channels are not enabled
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #2448:
URL: https://github.com/apache/incubator-nuttx/pull/2448#issuecomment-736269485
@diegoherranz The PWM output configuration was read from the wrong memory address (in my case it was <g_usart2txbuffer+12>). The fact that most of the time it worked properly was just a coincidence. We have been fooled by randomness :)
Thanks for finding the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] diegoherranz commented on pull request #2448: stm32/stm32h7: fix the configuration of PWM outputs when subsequent channels are not enabled
Posted by GitBox <gi...@apache.org>.
diegoherranz commented on pull request #2448:
URL: https://github.com/apache/incubator-nuttx/pull/2448#issuecomment-736032200
I've tested this on an STM32F103 and after dozens of attempts, I can't reproduce the issue I was seeing on https://github.com/apache/incubator-nuttx/issues/2446.
Just one question. Where did the randomness come from? I can't understand that.
Many thanks for the quick fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2448: stm32/stm32h7: fix the configuration of PWM outputs when subsequent channels are not enabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2448:
URL: https://github.com/apache/incubator-nuttx/pull/2448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org