[GitHub] [druid] belugabehr commented on a change in pull request #10683: Upgrade Guava to 27

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #10683:
URL: https://github.com/apache/druid/pull/10683#discussion_r551354743



##########
File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java
##########
@@ -905,12 +905,13 @@ public void testIncrementalHandOffReadsThroughEndOffsets() throws Exception
 
     final ListenableFuture<TaskStatus> normalReplicaFuture = runTask(normalReplica);
     // Simulating one replica is slower than the other
-    final ListenableFuture<TaskStatus> staleReplicaFuture = Futures.transform(
+    final ListenableFuture<TaskStatus> staleReplicaFuture = Futures.transformAsync(
         taskExec.submit(() -> {
           Thread.sleep(1000);
           return staleReplica;
         }),
-        (AsyncFunction<Task, TaskStatus>) this::runTask
+        (AsyncFunction<Task, TaskStatus>) this::runTask,
+        Execs.directExecutor()

Review comment:
       @wangyum
   Because upgrading Guava requires an explicit Executor passed to the method.  The previous behavior was to implicitly pass `directExecutor` if no Executor was provided.  I tried to pass the guava version and some maven build tool plugin rejected the change and directed me to use this instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org