unlink return checking

["Liam J. Foy" <li...@sepulcrum.org>]

First hello to everyone, am new to this list! :)

Second of all when browsing through the apache code branch 1.3 I have seen a few calls to unlink(2) without actually checking the return value. I believe that these should actually be checked. Do you all agree? or do you have a valid reason why we do not check the return value?

If you believe they should, just say so and I will mail in the patch(I have produced it already).

Thanks,
-- 
-Liam J. Foy
http://liamfoy.kerneled.org

Re: unlink return checking

[Jeff Trawick <tr...@gmail.com>]

On Thu, 30 Sep 2004 17:12:01 +0000, Liam J. Foy <li...@sepulcrum.org> wrote:
> First hello to everyone, am new to this list! :)
> 
> Second of all when browsing through the apache code branch 1.3 I have seen a few calls to unlink(2) without actually checking the return value. I believe that these should actually be checked. Do you all agree? or do you have a valid reason why we do not check the return value?
> 
> If you believe they should, just say so and I will mail in the patch(I have produced it already).

maybe you should just post the patch so we can see the context of the
unlink(); it is possible that there is no sense in checking the return
code from unlink() since there is nothing to be done about it anyway;
it is possible that there is no sense in checking the return code from
unlink() since we' aren't guaranteed that the file exists; depends on
the context