You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by apiri <gi...@git.apache.org> on 2016/02/07 00:40:44 UTC
[GitHub] nifi pull request: NIFI-1483 - ListFile warns of unable to delete ...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/206
NIFI-1483 - ListFile warns of unable to delete old state when there was none
Correcting logic in terms of when local persistence files are removed during the migration process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi nifi-1483
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #206
----
commit 869c9a04ee11725ef22c23b69d7df0309ec71b36
Author: Aldrin Piri <al...@apache.org>
Date: 2016-02-06T23:38:00Z
NIFI-1483 Correcting logic in terms of when local persistence files are removed during the migration process.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1483 - ListFile warns of unable to delete ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1483 - ListFile warns of unable to delete ...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-180922873
logic looks like it should cover all conditions, tests are reasonable, doing some tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1483 - ListFile warns of unable to delete ...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-180928291
@apiri - +1, works great. Only bit of weirdness, if the old state file was chmod 0400'ed (i.e., only read access) when I launched nifi, it was still deleted after migration. chattr +i'ing the file kept it from being deleted though. may be something for the migration guide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1483 - ListFile warns of unable to delete ...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-181135049
I'll merge this one in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---