You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Wendy Smoak (JIRA)" <de...@myfaces.apache.org> on 2006/11/02 23:48:17 UTC
[jira] Created: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
ASF Source Header and Copyright Notice Policy
---------------------------------------------
Key: MYFACES-1488
URL: http://issues.apache.org/jira/browse/MYFACES-1488
Project: MyFaces Core
Issue Type: Improvement
Reporter: Wendy Smoak
Priority: Blocker
Fix For: 1.1.5-SNAPSHOT
All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
http://www.apache.org/legal/src-headers.html
We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448205 ]
Grant Smith commented on MYFACES-1488:
--------------------------------------
I've started replacing all the headers. Should be completed today.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Wendy Smoak (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448556 ]
Wendy Smoak commented on MYFACES-1488:
--------------------------------------
There is already a build-tools module with a checkstyle config file:
http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/checkstyle.xml
The RegExp header there can be modified to match the new header.
However, it doesn't look like the Checkstyle report is enabled. http://myfaces.apache.org/impl/project-reports.html
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Paul Spencer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448291 ]
Paul Spencer commented on MYFACES-1488:
---------------------------------------
Grant,
Is their anything you need from me?
Paul Spencer
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by Paul Spencer <pa...@apache.org>.
Once the patch is committed, I will create and submit a patch for another project.
I have configured the Checkstyle to identify files needing the header updated. I did this by adding
configuration files to org.apache.myfaces.maven:build-tools and adding the Checkstyle v2.1 plugin
to pom.xml in various projects.
Should I open up a new issue and submit this as a patch?
Paul Spencer
Paul Spencer (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/MYFACES-1488?page=all ]
>
> Paul Spencer updated MYFACES-1488:
> ----------------------------------
>
> Status: Patch Available (was: Open)
>
>
>>ASF Source Header and Copyright Notice Policy
>>---------------------------------------------
>>
>> Key: MYFACES-1488
>> URL: http://issues.apache.org/jira/browse/MYFACES-1488
>> Project: MyFaces Core
>> Issue Type: Improvement
>> Reporter: Wendy Smoak
>> Priority: Blocker
>> Fix For: 1.1.5-SNAPSHOT
>>
>>
>>All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
>> http://www.apache.org/legal/src-headers.html
>>We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
>> http://code.google.com/p/arat/
>
>
Re: [jira] Updated: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by Paul Spencer <pa...@apache.org>.
Once the patch is committed, I will create and submit a patch for another project.
I have configured the Checkstyle to identify files needing the header updated. I did this by adding
configuration files to org.apache.myfaces.maven:build-tools and adding the Checkstyle v2.1 plugin
to pom.xml in various projects.
Should I open up a new issue and submit this as a patch?
Paul Spencer
Paul Spencer (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/MYFACES-1488?page=all ]
>
> Paul Spencer updated MYFACES-1488:
> ----------------------------------
>
> Status: Patch Available (was: Open)
>
>
>>ASF Source Header and Copyright Notice Policy
>>---------------------------------------------
>>
>> Key: MYFACES-1488
>> URL: http://issues.apache.org/jira/browse/MYFACES-1488
>> Project: MyFaces Core
>> Issue Type: Improvement
>> Reporter: Wendy Smoak
>> Priority: Blocker
>> Fix For: 1.1.5-SNAPSHOT
>>
>>
>>All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
>> http://www.apache.org/legal/src-headers.html
>>We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
>> http://code.google.com/p/arat/
>
>
[jira] Updated: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Paul Spencer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=all ]
Paul Spencer updated MYFACES-1488:
----------------------------------
Status: Patch Available (was: Open)
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Paul Spencer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448526 ]
Paul Spencer commented on MYFACES-1488:
---------------------------------------
Grant,
I was using the Checkstyle plugin to verify the file header matched the Apache license text when creating the patch submitted for this issue. I suspect this is a clean approach since it is integrated into the Maven build process. As an additional benefit, Checkstyle can also be used to detect other formatting issues, like unused imports...
I had started looking into the "Multimodule Configuration" [1] as a way of doing the configuration in one place and using it in many modules. But I was waiting on feedback on the patch and mailing list post related to this issue.
As to "what next".
1) A new JIRA Issue should be create for implementing Checkstyle, RAT,...
2) If you want to take the lead on this, it is OK with me. If you want me to take the lead, I will but I will be dependent on a MyFaces committer since I am not one.
Paul Spencer
[1] http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Wendy Smoak (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12450766 ]
Wendy Smoak commented on MYFACES-1488:
--------------------------------------
If it was developed at or contributed to the ASF, yes, it should have a license header. (Third party works get mentioned in the NOTICE file, but I imagine that's more of an issue in Tomahawk.)
I'm not set up to run RAT yet, can you post the output somewhere so I can take a look?
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12450188 ]
Grant Smith commented on MYFACES-1488:
--------------------------------------
I have applied the patch from MYFACES-1491. Then I ran RAT against current and was overwhelmed by the output. It is basically a fancy grep at the moment. It reports on every single non-binary file and states what it's licence (if any) is. We have hundreds and hundreds of .xml, .js files that dont have the ASL header. At this point I'm not sure what the next step should be. Do we have to include the ASL header on every single file ?
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Paul Spencer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12449878 ]
Paul Spencer commented on MYFACES-1488:
---------------------------------------
Glen,
What is the status of your work on this issue?
Paul Spencer
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Paul Spencer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448647 ]
Paul Spencer commented on MYFACES-1488:
---------------------------------------
Wendy,
I have created an issue, https://issues.apache.org/jira/browse/MYFACES-1491, and attached a patch to resolve the issue.
Paul Spencer
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=comments#action_12448522 ]
Grant Smith commented on MYFACES-1488:
--------------------------------------
I think I got them all. I didnt have time to look at RAT though; maybe that will find something else. Paul, if you like (and have time) you can test RAT on the Myfaces sources. Otherwise I'll try get to that later in the week
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Priority: Blocker
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1488) ASF Source Header and Copyright
Notice Policy
Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1488?page=all ]
Grant Smith updated MYFACES-1488:
---------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Headers and notice files have been updated. We'll open a new issue for the RAT analysis.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: MYFACES-1488
> URL: http://issues.apache.org/jira/browse/MYFACES-1488
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Wendy Smoak
> Assigned To: Grant Smith
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: rat_results.zip, shared-core.patch
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> We could also run Robert Burrell Donkin's "RAT" (release audit tool) to see if anything else is missing
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira