You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/06/19 09:10:37 UTC
[GitHub] [arrow] kou opened a new pull request, #36160: GH-36117: [C++] Ensure creating BUILD_OUTPUT_ROOT_DIRECTORY
kou opened a new pull request, #36160:
URL: https://github.com/apache/arrow/pull/36160
### Rationale for this change
If it doesn't exist when we build arrow_bundled_dependencies.lib, "lib.exe ..." failed.
### What changes are included in this PR?
Ensure creating it in `cmake ...` phase not build phrase.
This also includes cleanup of lib.exe detection related codes but it's not related of this fix. Sorry. "file(MAKE_DIRECTORY)" is only important.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36160: GH-36117: [C++] Ensure creating BUILD_OUTPUT_ROOT_DIRECTORY
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36160:
URL: https://github.com/apache/arrow/pull/36160#issuecomment-1601394320
Conbench analyzed the 6 benchmark runs on commit `7513a3ed`.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `ursa-thinkcentre-m75q` at [2023-06-21 15:30:23Z](http://conbench.ursa.dev/compare/runs/1aa8da09a11d4d9689c71d0874c946d4...19d4cc4e41584e14ac2805951be4076b/)
- [params=32768/100, source=cpp-micro, suite=arrow-compare-benchmark](http://conbench.ursa.dev/compare/benchmarks/06492f204af17d928000221de3c9ea59...0649318734f972b080004691eb47a168)
The [full Conbench report](https://github.com/apache/arrow/runs/14448614652) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36160: GH-36117: [C++] Ensure creating BUILD_OUTPUT_ROOT_DIRECTORY
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36160:
URL: https://github.com/apache/arrow/pull/36160#issuecomment-1599989469
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36160: GH-36117: [C++] Ensure creating BUILD_OUTPUT_ROOT_DIRECTORY
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36160:
URL: https://github.com/apache/arrow/pull/36160#issuecomment-1596809735
:warning: GitHub issue #36117 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36160: GH-36117: [C++] Ensure creating BUILD_OUTPUT_ROOT_DIRECTORY
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36160:
URL: https://github.com/apache/arrow/pull/36160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org