[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9602: the doc of DagHelperTest generateDag2 is not correct.

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #9602:
URL: https://github.com/apache/dolphinscheduler/pull/9602#discussion_r854745316


##########
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java:
##########
@@ -280,9 +280,15 @@ public void testConditionPostNode() throws IOException {
     }
 
     /**
+     * process:
      * 1->2->3->5->7
      * 4->3->6
-     * 2->8->5->7
+     * 1->2->8->5->7
+     * DAG graph:
+     *    8->5->7
+     *    ↑  ↑
+     * 1->2->3->6
+     *    4-↗

Review Comment:
   I have an experience in Python api about draw a graph about DAG, and maybe we should keep the longest flow into online `1-2-3-5-7` and the finial is like
   
   ```suggestion
        *      4 ->   -> 6
        *          \ /
        * 1 -> 2 -> 3 -> 5 -> 7
        *       \       /
        *        -> 8 ->
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org