You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "akashchamp (via GitHub)" <gi...@apache.org> on 2026/09/11 19:32:18 UTC
[PR] Fix filtered graph resolved artifacts [maven-dependency-analyzer]
akashchamp opened a new pull request, #302:
URL: https://github.com/apache/maven-dependency-analyzer/pull/302
Closes #301
## Summary
DependencyGraphProject copies the source MavenProject, including its resolved
artifact set. The filtered graph replaces getDependencyArtifacts() with null,
but the inherited getArtifacts() still exposes that copied resolved state to
ProjectDependenciesResolver. As a result, a candidate intentionally excluded
from the graph can still be considered resolved.
Override getArtifacts() as well, so the resolver obtains the graph's filtered
dependency state. The regression test verifies that the copied resolved artifacts
are no longer exposed.
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
- [x] Run mvn verify to make sure basic checks pass.
- [x] You have run the integration tests successfully (mvn -Prun-its verify).
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix filtered graph resolved artifacts [maven-dependency-analyzer]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #302:
URL: https://github.com/apache/maven-dependency-analyzer/pull/302#issuecomment-5742751471
add tests please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix filtered graph resolved artifacts [maven-dependency-analyzer]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #302:
URL: https://github.com/apache/maven-dependency-analyzer/pull/302#issuecomment-5742851267
Thanks for the quick turnaround, but this can't land: #301's premise does not hold. `DefaultProjectDependenciesResolver` in maven-core 3.9.16 collects from `getDependencyArtifacts()` (already null here) or `getDependencies()`, never from `getArtifacts()`, so the new override is a no-op for the resolver, and the updated test only asserts the override itself. I built this branch as 1.17.3-SNAPSHOT and ran apache/maven-dependency-plugin's `analyze-testDependencyWithNonTestScope` IT against it: it fails identically to 1.17.2. The candidate in that IT is genuinely reachable at compile scope (`maven-project:2.0.6 → plexus-container-default → junit:3.8.1`), which is the case #294 was written to suppress. The fix belongs in the plugin IT; closing this together with #301.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix filtered graph resolved artifacts [maven-dependency-analyzer]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #302: Fix filtered graph resolved artifacts
URL: https://github.com/apache/maven-dependency-analyzer/pull/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org