You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2009/01/18 11:14:51 UTC

svn commit: r735427 - /activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java

Author: davsclaus
Date: Sun Jan 18 02:14:50 2009
New Revision: 735427

URL: http://svn.apache.org/viewvc?rev=735427&view=rev
Log:
CAMEL-1263: Closing mailbox folder can cause MessagingException on some mail servers that block the folder. This is now ignored and debug logged.

Modified:
    activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java

Modified: activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java?rev=735427&r1=735426&r2=735427&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java (original)
+++ activemq/camel/trunk/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailConsumer.java Sun Jan 18 02:14:50 2009
@@ -25,7 +25,6 @@
 import javax.mail.search.FlagTerm;
 
 import org.apache.camel.Processor;
-import org.apache.camel.impl.DefaultEndpoint;
 import org.apache.camel.impl.ScheduledPollConsumer;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -110,8 +109,13 @@
             }
         } finally {
             // need to ensure we release resources
-            if (folder.isOpen()) {
-                folder.close(true);
+            try {
+                if (folder.isOpen()) {
+                    folder.close(true);
+                }
+            } catch (MessagingException e) {
+                // some mail servers will lock the folder so we ignore in this case (CAMEL-1263)
+                LOG.debug("Could not close mailbox folder: " + folder.getName(), e);
             }
         }
     }