You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Steffen Stundzig <st...@smb-tec.com> on 2001/06/22 16:00:41 UTC
[C2][Patch]AbstractSitemap
Hi,
if I wish to replace a key in the sitemap with the normal sitemap substition
mechanism and the key doesn't exists in the current substitution maps I get an
NullPointerException.
The reason is, that the method toString() is called on the return value of the
map, but it's not checked, if this is null.
Regards
Steffen...
--
______________________________________________________________________
Steffen Stundzig mailto:steffen@smb-tec.com
SMB GmbH http://www.smb-tec.com
RE: [C2][Patch]AbstractSitemap
Posted by Vadim Gritsenko <vg...@hns.com>.
I'm going to fix it.
> -----Original Message-----
> From: Davanum Srinivas [mailto:dims@yahoo.com]
> Sent: Friday, June 22, 2001 10:20
> To: cocoon-dev@xml.apache.org
> Subject: Re: [C2][Patch]AbstractSitemap
>
>
> Steffen,
>
> The sources don't match. Please re-submit the patch against the latest AbstractSitemap.java from
> CVS.
>
> Thanks,
> dims
>
> --- Steffen Stundzig <st...@smb-tec.com> wrote:
> > Hi,
> >
> > if I wish to replace a key in the sitemap with the normal sitemap substition
> > mechanism and the key doesn't exists in the current substitution maps I get an
> > NullPointerException.
> >
> > The reason is, that the method toString() is called on the return value of the
> > map, but it's not checked, if this is null.
> >
> > Regards
> > Steffen...
> >
> > --
> > ______________________________________________________________________
> > Steffen Stundzig mailto:steffen@smb-tec.com
> > SMB GmbH http://www.smb-tec.com
> >
> >
> >
> >
>
> > ATTACHMENT part 2 application/octet-stream name=AbstractSitemap.java.diff
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
> =====
> Davanum Srinivas, JNI-FAQ Manager
> http://www.jGuru.com/faq/JNI
>
> __________________________________________________
> Do You Yahoo!?
> Get personalized email addresses from Yahoo! Mail
> http://personal.mail.yahoo.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [C2][Patch]AbstractSitemap
Posted by Davanum Srinivas <di...@yahoo.com>.
Vadim,
Thanks. Here's a note of caution. Please test the samples often. We should try to enhance the
Out-Of-The-Box experience for as many people as possible.
Thanks,
dims
--- Vadim Gritsenko <vg...@hns.com> wrote:
> Dims,
>
> Fixed, and log added, and internationalization works :)
>
> Steffen,
>
> I slightly modified your patch but idea should remain same. Please check.
>
>
> Regards,
> Vadim
>
> > -----Original Message-----
> > From: Davanum Srinivas [mailto:dims@yahoo.com]
> > Sent: Friday, June 22, 2001 10:20
> > To: cocoon-dev@xml.apache.org
> > Subject: Re: [C2][Patch]AbstractSitemap
> >
> >
> > Steffen,
> >
> > The sources don't match. Please re-submit the patch against the latest AbstractSitemap.java
> from
> > CVS.
> >
> > Thanks,
> > dims
> >
> > --- Steffen Stundzig <st...@smb-tec.com> wrote:
> > > Hi,
> > >
> > > if I wish to replace a key in the sitemap with the normal sitemap substition
> > > mechanism and the key doesn't exists in the current substitution maps I get an
> > > NullPointerException.
> > >
> > > The reason is, that the method toString() is called on the return value of the
> > > map, but it's not checked, if this is null.
> > >
> > > Regards
> > > Steffen...
> > >
> > > --
> > > ______________________________________________________________________
> > > Steffen Stundzig mailto:steffen@smb-tec.com
> > > SMB GmbH http://www.smb-tec.com
> > >
> > >
> > >
> > >
> >
> > > ATTACHMENT part 2 application/octet-stream name=AbstractSitemap.java.diff
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
> > =====
> > Davanum Srinivas, JNI-FAQ Manager
> > http://www.jGuru.com/faq/JNI
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Get personalized email addresses from Yahoo! Mail
> > http://personal.mail.yahoo.com/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
=====
Davanum Srinivas, JNI-FAQ Manager
http://www.jGuru.com/faq/JNI
__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail
http://personal.mail.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [C2][Patch]AbstractSitemap
Posted by Vadim Gritsenko <vg...@hns.com>.
Dims,
Fixed, and log added, and internationalization works :)
Steffen,
I slightly modified your patch but idea should remain same. Please check.
Regards,
Vadim
> -----Original Message-----
> From: Davanum Srinivas [mailto:dims@yahoo.com]
> Sent: Friday, June 22, 2001 10:20
> To: cocoon-dev@xml.apache.org
> Subject: Re: [C2][Patch]AbstractSitemap
>
>
> Steffen,
>
> The sources don't match. Please re-submit the patch against the latest AbstractSitemap.java from
> CVS.
>
> Thanks,
> dims
>
> --- Steffen Stundzig <st...@smb-tec.com> wrote:
> > Hi,
> >
> > if I wish to replace a key in the sitemap with the normal sitemap substition
> > mechanism and the key doesn't exists in the current substitution maps I get an
> > NullPointerException.
> >
> > The reason is, that the method toString() is called on the return value of the
> > map, but it's not checked, if this is null.
> >
> > Regards
> > Steffen...
> >
> > --
> > ______________________________________________________________________
> > Steffen Stundzig mailto:steffen@smb-tec.com
> > SMB GmbH http://www.smb-tec.com
> >
> >
> >
> >
>
> > ATTACHMENT part 2 application/octet-stream name=AbstractSitemap.java.diff
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
> =====
> Davanum Srinivas, JNI-FAQ Manager
> http://www.jGuru.com/faq/JNI
>
> __________________________________________________
> Do You Yahoo!?
> Get personalized email addresses from Yahoo! Mail
> http://personal.mail.yahoo.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
Re: [C2][Patch]AbstractSitemap
Posted by Davanum Srinivas <di...@yahoo.com>.
Steffen,
The sources don't match. Please re-submit the patch against the latest AbstractSitemap.java from
CVS.
Thanks,
dims
--- Steffen Stundzig <st...@smb-tec.com> wrote:
> Hi,
>
> if I wish to replace a key in the sitemap with the normal sitemap substition
> mechanism and the key doesn't exists in the current substitution maps I get an
> NullPointerException.
>
> The reason is, that the method toString() is called on the return value of the
> map, but it's not checked, if this is null.
>
> Regards
> Steffen...
>
> --
> ______________________________________________________________________
> Steffen Stundzig mailto:steffen@smb-tec.com
> SMB GmbH http://www.smb-tec.com
>
>
>
>
> ATTACHMENT part 2 application/octet-stream name=AbstractSitemap.java.diff
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
=====
Davanum Srinivas, JNI-FAQ Manager
http://www.jGuru.com/faq/JNI
__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail
http://personal.mail.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org