You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2018/03/09 13:53:16 UTC

[GitHub] flink pull request #5521: [FLINK-8599] Improve the failure behavior of the F...

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5521#discussion_r173454031
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
    @@ -819,6 +819,10 @@ public void open(FileInputSplit fileSplit) throws IOException {
     			this.stream = isot.waitForCompletion();
     			this.stream = decorateInputStream(this.stream, fileSplit);
     		}
    +		catch (FileNotFoundException e) {
    +			throw (FileNotFoundException)(new FileNotFoundException("Input split " + fileSplit.getPath() +
    --- End diff --
    
    I don't understand why "skip and continue" is in this message.
    Not all users of the `FileIputFormat` skip and continue. The interpretation of the exception should not be assumed when creating the exception.


---