[jira] [Commented] (SAMZA-1162) review tryBecomeLeader implementation to see if it can be simplified.

["Boris Shkolnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937238#comment-15937238 ] 

Boris Shkolnik commented on SAMZA-1162:
---------------------------------------

Comment from Navina regarding this code:
We need this check and re-try because zkClient does not throw exceptions or fail when it tries to subscribe to a non-existent path. This is needed for a non-leader when it tries to subscribe to a predecessor node. If the node went away when the follower tried to subscribe to changes, it won't get any callbacks and will be orphaned. In order to avoid that scenario, we check with an "exists" of the predecessor node AFTER subscription. If it doesn't exist, we need to re-try leader election.

> review tryBecomeLeader implementation to see if it can be simplified.
> ---------------------------------------------------------------------
>
>                 Key: SAMZA-1162
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1162
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.13.0
>
>
> In particular, see if recursive call can be avoided.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)