You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/14 23:47:42 UTC

Review Request 15548: [HELIX-306] helix-agent package doesn't create an assembled tar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15548/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-306


Repository: helix-git


Description
-------

commit 1e63e758cd7eb8133b88345040982f59c56ff02b
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Thu Nov 14 14:42:58 2013 -0800

    [HELIX-306] helix-agent package doesn't create an assembled tar

:000000 100644 0000000... 2001d31... A	helix-agent/DISCLAIMER
:000000 100644 0000000... 413913f... A	helix-agent/LICENSE
:000000 100644 0000000... e070e15... A	helix-agent/NOTICE
:100644 100644 24feb50... 9558b15... M	helix-agent/pom.xml
:000000 100644 0000000... c2d08a1... A	helix-agent/src/assemble/assembly.xml


Diffs
-----

  helix-agent/DISCLAIMER PRE-CREATION 
  helix-agent/LICENSE PRE-CREATION 
  helix-agent/NOTICE PRE-CREATION 
  helix-agent/pom.xml 24feb50 
  helix-agent/src/assemble/assembly.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/15548/diff/


Testing
-------

tar created, builds, rat passes


Thanks,

Kanak Biscuitwala


Re: Review Request 15548: [HELIX-306] helix-agent package doesn't create an assembled tar

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15548/#review28922
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On Nov. 14, 2013, 10:47 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15548/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 10:47 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-306
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 1e63e758cd7eb8133b88345040982f59c56ff02b
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Thu Nov 14 14:42:58 2013 -0800
> 
>     [HELIX-306] helix-agent package doesn't create an assembled tar
> 
> :000000 100644 0000000... 2001d31... A	helix-agent/DISCLAIMER
> :000000 100644 0000000... 413913f... A	helix-agent/LICENSE
> :000000 100644 0000000... e070e15... A	helix-agent/NOTICE
> :100644 100644 24feb50... 9558b15... M	helix-agent/pom.xml
> :000000 100644 0000000... c2d08a1... A	helix-agent/src/assemble/assembly.xml
> 
> 
> Diffs
> -----
> 
>   helix-agent/DISCLAIMER PRE-CREATION 
>   helix-agent/LICENSE PRE-CREATION 
>   helix-agent/NOTICE PRE-CREATION 
>   helix-agent/pom.xml 24feb50 
>   helix-agent/src/assemble/assembly.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15548/diff/
> 
> 
> Testing
> -------
> 
> tar created, builds, rat passes
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>