You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/22 02:14:40 UTC

[GitHub] [kafka] ccding commented on pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

ccding commented on pull request #10763:
URL: https://github.com/apache/kafka/pull/10763#issuecomment-865468006


   @dhruvilshah3 @junrao This PR is ready for review. Please take a look
   
   https://github.com/apache/kafka/blob/f914ed73e9de028d2e6bb1353cec02bcc2275c19/core/src/test/scala/unit/kafka/log/LogCleanerTest.scala#L1407
   The above function tests all the possible cases, thus we don't need additional tests.
   
   One thing I am not sure about is how to test whether certain recovery goes the renaming path or recovery path. Current test cases only validate the results are correct. If you have any ideas, please let me know.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org