You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/21 13:01:37 UTC

[GitHub] [incubator-superset] agatapst opened a new pull request #12156: fix: Filter Bar scrolling

agatapst opened a new pull request #12156:
URL: https://github.com/apache/incubator-superset/pull/12156


   ### SUMMARY
   This PR fixes bug in Filter Bar. When there was many filters added, Filter Bar scrolling did not work properly, as presented below.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   ![filter_bar_scrolling_before](https://user-images.githubusercontent.com/47450693/102779517-ab1da680-4394-11eb-8ba4-90e4fc688c9d.gif)
    
   After:
   ![filter_bar_scrolling_after](https://user-images.githubusercontent.com/47450693/102779531-b07af100-4394-11eb-922e-d598b34e2a66.gif)
   
   ### TEST PLAN
   Set feature flag `DASHBOARD_NATIVE_FILTERS` to true. 
   Go to Dashboards, choose one and create a bunch of Filters. Try to scroll Filter Bar up and down.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @rusackas @villebro @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] adam-stasiak commented on pull request #12156: fix: Filter Bar scrolling

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12156:
URL: https://github.com/apache/incubator-superset/pull/12156#issuecomment-749460819


   Tested - OK!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #12156: fix: Filter Bar scrolling

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12156:
URL: https://github.com/apache/incubator-superset/pull/12156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org