[GitHub] [helix] alirezazamani commented on a change in pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.
URL: https://github.com/apache/helix/pull/344#discussion_r305914218
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/CrushRebalanceStrategy.java
 ##########
 @@ -89,7 +89,16 @@ public ZNRecord computePartitionAssignment(final List<String> allNodes,
       long data = partitionName.hashCode();
 
       // apply the placement rules
-      List<Node> selected = select(topNode, data, _replicas, eventId);
+      List<Node> selected;
+      try {
+        selected = select(topNode, data, _replicas, eventId);
+      } catch (IllegalStateException e) {
+        String errorMessage = String
+            .format("Could not select enough number of nodes. %s partition %s, required %d",
+                _resourceName, partitionName, _replicas);
+        LogUtil.logError(Log, eventId, errorMessage);
 
 Review comment:
   Seems it is because there was a conflict in my two pull request which has not been approved yet. I will cancel this pull request and try to issue two separate non-conflicting pull requests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services