You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2019/05/29 14:08:00 UTC

[jira] [Resolved] (OAK-8372) DeclaredMembershipPredicate contains redundant lookup of groupTree

     [ https://issues.apache.org/jira/browse/OAK-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-8372.
-------------------------
    Resolution: Fixed

Committed revision 1860349.


> DeclaredMembershipPredicate contains redundant lookup of groupTree
> ------------------------------------------------------------------
>
>                 Key: OAK-8372
>                 URL: https://issues.apache.org/jira/browse/OAK-8372
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> line 52 in {{DeclaredMembershipPredicate}} retrieves the _groupTree_ again instead of using the value of the lookup obtained earlier. While fixing this i additionally noticed that the contentIds obtained on the same line could be filtered for non-null values. this improvement would allow to consequently drop the extra check for null in the {{apply}} method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)