You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/10 18:00:19 UTC
[GitHub] [fineract] xurror opened a new pull request #882: bump flyway from 2.1.1 to 6.4.1
xurror opened a new pull request #882:
URL: https://github.com/apache/fineract/pull/882
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #882: bump flyway from 2.1.1 to 6.4.1
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #882:
URL: https://github.com/apache/fineract/pull/882#issuecomment-626628661
Wooow...this finally worked? Thank you both very much. What happened that drizzle or something else stopped having problems wrt Flyway? Just curious...is it the new upgrades we made ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #882: bump flyway from 2.1.1 to 6.4.1
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #882:
URL: https://github.com/apache/fineract/pull/882#issuecomment-626463998
@ptuomola, @awasum is it OK for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #882: bump flyway from 2.1.1 to 6.4.1
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #882:
URL: https://github.com/apache/fineract/pull/882#issuecomment-626416015
> @xurror the change to `V204__insert_script_for_charges_paid_by_for_accruals.sql` just adds a missing semicolon at the end?
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #882: bump flyway from 2.1.1 to 6.4.1
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #882:
URL: https://github.com/apache/fineract/pull/882#issuecomment-626464182
@vorburger, conflicts are resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org