[GitHub] [spark] srowen commented on pull request #34187: [SPARK-29871][ML] Catch IIOException for signaling run-time failure of reading in image source

[GitBox <gi...@apache.org>]

srowen commented on pull request #34187:
URL: https://github.com/apache/spark/pull/34187#issuecomment-935162666


   Tough one. I assume we want to return 'null' when trying to read an invalid or unsupported file, but fail outright in case of an I/O problem. This sounds like a type of "I/O problem", but, it does appear to arise when the data was read just fine but the data isn't supported or doesn't make sense: https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java#L1068 So yes this seems reasonable.
   
   yes, weird that it happens only sometimes in a test though ... maybe a corrupted checkout on a worker?
   
   After this, we'd be unexpectedly getting a null for some image in this test - is that just irrelevant for the test?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org