[GitHub] [hudi] hbgstc123 commented on a diff in pull request #8232: [HUDI-5955] fix incremental clean not work caused by archive

["hbgstc123 (via GitHub)" <gi...@apache.org>]

hbgstc123 commented on code in PR #8232:
URL: https://github.com/apache/hudi/pull/8232#discussion_r1141622129


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -474,13 +477,36 @@ private Stream<HoodieInstant> getCommitInstantsToArchive() throws IOException {
               oldestInstantToRetainForClustering.map(instantToRetain ->
                       HoodieTimeline.compareTimestamps(s.getTimestamp(), LESSER_THAN, instantToRetain.getTimestamp()))
                   .orElse(true)
+          ).filter(s ->
+              latestCleanRetainedInstant.map(instant ->
+                      compareTimestamps(s.getTimestamp(), LESSER_THAN, instant))

Review Comment:
   we can fallback to full cleaning if there are archived retained commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org