[GitHub] [calcite] jinxing64 commented on a change in pull request #1520: [CALCITE-3428] Refine RelMdColumnUniqueness for Filter by considering…

[GitBox <gi...@apache.org>]

jinxing64 commented on a change in pull request #1520: [CALCITE-3428] Refine RelMdColumnUniqueness for Filter by considering…
URL: https://github.com/apache/calcite/pull/1520#discussion_r336762499
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
 ##########
 @@ -3986,7 +3986,7 @@ private HepProgram getTransitiveProgram() {
         .addRuleInstance(AggregateProjectMergeRule.INSTANCE)
         .build();
     final String sql = "select e.job,d.name\n"
-        + "from (select * from sales.emp where empno = 10) as e\n"
+        + "from (select * from sales.emp where ename = 'A') as e\n"
 
 Review comment:
   Q：Why this change ?
   A：empno is key column of sales.emp. This test targets to verify Aggregate pushing down, but with `empno=10`, the Aggregate can be regarded as redundant and can be optimized/removed. In order to keep the original testing intention, I replaced by `ename = 'A'`,  where `ename` is not a key column, thus `Aggregate` should be kept.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services