You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "song bruce zhang (Code Review)" <ge...@cloudera.org> on 2016/05/01 16:40:13 UTC

[kudu-CR] KUDU-1436. Concurrent remote bootstrap session starts can crash or corrupt tablets

song bruce zhang has posted comments on this change.

Change subject: KUDU-1436. Concurrent remote bootstrap session starts can crash or corrupt tablets
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2913/1/src/kudu/tserver/remote_bootstrap_session.cc
File src/kudu/tserver/remote_bootstrap_session.cc:

Line 74: std
As have already removed calling "session->init" in else of  BeginRemoteBootstrapSession  in remote_bootstrap_service.cc
What the "if(!l.owns_lock())" and "if (initted_)" used for? Is it a double check or some other consideration?


-- 
To view, visit http://gerrit.cloudera.org:8080/2913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ec55e7b51da9e7c795c18146f04d539d1e44ccd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: song bruce zhang <zs...@gmail.com>
Gerrit-HasComments: Yes