You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/08 01:27:41 UTC

[GitHub] [iotdb] HTHou commented on a diff in pull request #5416: [IOTDB-2772] Add testcontainer e2e test for newsync

HTHou commented on code in PR #5416:
URL: https://github.com/apache/iotdb/pull/5416#discussion_r867421342


##########
.github/workflows/e2e.yml:
##########
@@ -58,4 +59,5 @@ jobs:
 
       - name: TestContainer
         run: |
-          mvn -B -T 4 integration-test -pl testcontainer
+#          TODO: add cluster test
+          mvn -B -T 4 integration-test -pl testcontainer -P sync

Review Comment:
   IMO, one workflow is for one kind of test. We don’t need to test other modules in sync test at all…
   
   We actually going to abandon the e2e test for cluster since we are refactoring the IT framework for new cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org