You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/17 22:53:00 UTC
[jira] [Work logged] (BEAM-6460) PipelineOptionsFactory may hold on
to Classloader after pipeline restart
[ https://issues.apache.org/jira/browse/BEAM-6460?focusedWorklogId=186605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186605 ]
ASF GitHub Bot logged work on BEAM-6460:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 22:52
Start Date: 17/Jan/19 22:52
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7552: [BEAM-6460] Remove cached class references upon start/shutdown
URL: https://github.com/apache/beam/pull/7552
The Flink Classloader can only be garbage collected if the classes it loaded are
not referenced anymore. Users have reported that old classes leaked through
Jackson's TypeFactory after pipeline restart.
I realized that PipelineOptionsFactory also has a cache which looks like it
could hold class references.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 186605)
Time Spent: 10m
Remaining Estimate: 0h
> PipelineOptionsFactory may hold on to Classloader after pipeline restart
> ------------------------------------------------------------------------
>
> Key: BEAM-6460
> URL: https://issues.apache.org/jira/browse/BEAM-6460
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.7.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Blocker
> Fix For: 2.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It looks like Jackson has an internal cache which may continue to hold the Flink application classloader through its {{TypeFactory}} class. When the pipeline is restarted due to a failure, a new classloader is created which can result in too many classes being loaded.
> Reported on the user mailing list: https://lists.apache.org/thread.html/e201891684ef3dcffce48d20d1f9be0e19fc2294334362cc7092c0ff@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)