You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2015/11/29 02:27:32 UTC
incubator-zeppelin git commit: Fix 'create' -> 'cancel' -> 'create'
in interpreters page
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 6702e8ee9 -> dff32b2a3
Fix 'create' -> 'cancel' -> 'create' in interpreters page
Fix for the following scenario
1. click 'create' button in interpreters page. Interpreter creation form shows up
2. click 'cancel' button in interpreters page. Interprete creation form is hidden
2.click 'create' button again. Nothiing happens.
Author: karuppayya <ka...@gmail.com>
Closes #473 from Karuppayya/fix-create-intp and squashes the following commits:
df31591 [karuppayya] Fix display of 'new interpreter form'
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/dff32b2a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/dff32b2a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/dff32b2a
Branch: refs/heads/master
Commit: dff32b2a3aec9059da86e624254fd203846e69e9
Parents: 6702e8e
Author: karuppayya <ka...@gmail.com>
Authored: Wed Nov 25 15:37:12 2015 +0530
Committer: Lee moon soo <mo...@apache.org>
Committed: Sun Nov 29 10:28:21 2015 +0900
----------------------------------------------------------------------
.../app/interpreter/interpreter-create/interpreter-create.html | 4 ++--
zeppelin-web/src/app/interpreter/interpreter.controller.js | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/dff32b2a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
index b181ed3..38ae7cc 100644
--- a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
+++ b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
@@ -70,10 +70,10 @@ limitations under the License.
<span class="btn btn-primary" ng-click="addNewInterpreterSetting()">
Save
</span>
- <span class="btn btn-default" ng-click="showAddNewSetting=false">
+ <span class="btn btn-default" ng-click="cancelInterpreterSetting()">
Cancel
</span>
</div>
</div>
</div>
-</div>
\ No newline at end of file
+</div>
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/dff32b2a/zeppelin-web/src/app/interpreter/interpreter.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js
index c363115..db000c8 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.controller.js
+++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js
@@ -163,6 +163,10 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', function($scope,
});
};
+ $scope.cancelInterpreterSetting = function() {
+ $scope.showAddNewSetting = false;
+ };
+
$scope.resetNewInterpreterSetting = function() {
$scope.newInterpreterSetting = {
name : undefined,