You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/04 16:26:41 UTC
[GitHub] [arrow] jonkeane opened a new pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
jonkeane opened a new pull request #11308:
URL: https://github.com/apache/arrow/pull/11308
Until DuckDB's unregister function can be called without a `SELECT` let's turn this off (but allow people to turn it on if they want)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #11308:
URL: https://github.com/apache/arrow/pull/11308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #11308:
URL: https://github.com/apache/arrow/pull/11308#issuecomment-933717066
All green on the CI. I probably shouldn't have merged #11307 until this was ready, but it is now (and will ensure that the duckdb cleanup doesn't pop up in our CI)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11308:
URL: https://github.com/apache/arrow/pull/11308#issuecomment-933649371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #11308:
URL: https://github.com/apache/arrow/pull/11308#discussion_r721644450
##########
File path: r/R/duckdb.R
##########
@@ -29,7 +29,7 @@
#' @param table_name a name to use in DuckDB for this object. The default is a
#' unique string `"arrow_"` followed by numbers.
#' @param auto_disconnect should the table be automatically cleaned up when the
-#' resulting object is removed (and garbage collected)? Default: `TRUE`
+#' resulting object is removed (and garbage collected)? Default: `FALSE`
Review comment:
I added it to the description so the argument isn't super super long, but I can move it if you think it's better in the argument documentation block itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #11308: ARROW-14216: [R] Disable auto-cleaning of duckdb tables
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #11308:
URL: https://github.com/apache/arrow/pull/11308#discussion_r721595946
##########
File path: r/R/duckdb.R
##########
@@ -29,7 +29,7 @@
#' @param table_name a name to use in DuckDB for this object. The default is a
#' unique string `"arrow_"` followed by numbers.
#' @param auto_disconnect should the table be automatically cleaned up when the
-#' resulting object is removed (and garbage collected)? Default: `TRUE`
+#' resulting object is removed (and garbage collected)? Default: `FALSE`
Review comment:
Can you add a note explaining the consequences of cleaning up, or choosing not to clean up? As a user, I see that there is an option, but I have no idea why I would want to change the value or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org