[GitHub] [ozone] Xushaohong commented on a diff in pull request #4992: HDDS-7750. Incorrect WRITE ACL check

["Xushaohong (via GitHub)" <gi...@apache.org>]

Xushaohong commented on code in PR #4992:
URL: https://github.com/apache/ozone/pull/4992#discussion_r1246516052


##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3MultipartRequest.java:
##########
@@ -83,6 +84,8 @@ public void setup() throws Exception {
     when(ozoneManager.getMetrics()).thenReturn(omMetrics);
     when(ozoneManager.getMetadataManager()).thenReturn(omMetadataManager);
     auditLogger = Mockito.mock(AuditLogger.class);
+    OmMetadataReader omMetadataReader = Mockito.mock(OmMetadataReader.class);
+    when(ozoneManager.getOmMetadataReader()).thenReturn(omMetadataReader);

Review Comment:
   This line is duplicated with line 85. Need to verify if the mock is necessary.
   `when(ozoneManager.getMetadataManager()).thenReturn(omMetadataManager);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org