You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/09/22 20:01:00 UTC
[GitHub] [beam] damccorm opened a new pull request, #28627: Run arm suite against all validates_container tests
damccorm opened a new pull request, #28627:
URL: https://github.com/apache/beam/pull/28627
This will give us the same level of confidence that we have with normal python containers
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #28627: Run arm suite against all validates_container tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28627:
URL: https://github.com/apache/beam/pull/28627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1732005429
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28627](https://app.codecov.io/gh/apache/beam/pull/28627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ae45640) into [master](https://app.codecov.io/gh/apache/beam/commit/97dea715f8f3d9e5d8d097105aac9f41f1a4c519?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (97dea71) will **not change** coverage.
> Report is 4 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #28627 +/- ##
=======================================
Coverage 72.20% 72.20%
=======================================
Files 684 684
Lines 101131 101131
=======================================
Hits 73021 73021
Misses 26531 26531
Partials 1579 1579
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28627/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/28627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1733906553
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1736056799
> LGTM. Looks like the only test we are adding atm is sibling_sdk_worker IT test (still a wordcount test; we can remove that test next week). Running all tests could help with future ValCont tests but wouldn't significantly increase coverage now.
And https://github.com/apache/beam/blob/a7e12db9b5977c4a7b13554605c0300389a3d6da/sdks/python/apache_beam/runners/dataflow/dataflow_exercise_metrics_pipeline_test.py#L55 if its not skipped. But yeah, the idea is to knock out the low hanging fruit and then move on to general python postcommit. There's some issues with the normal Python PostCommit suite at the moment, so I'm waiting on those to be fixed before moving forward with that piece.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1733670123
Run Python_Coverage PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #28627: Run arm suite against all validates_container tests
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28627:
URL: https://github.com/apache/beam/pull/28627#discussion_r1337609051
##########
sdks/python/apache_beam/examples/wordcount_it_test.py:
##########
@@ -112,14 +112,14 @@ def test_wordcount_it_with_prebuilt_sdk_container_cloud_build(self):
def test_wordcount_it_with_use_sibling_sdk_workers(self):
self._run_wordcount_it(wordcount.run, experiment='use_sibling_sdk_workers')
- @pytest.mark.it_dataflow_arm
- def test_wordcount_fnapi_it_arm(self):
- self._run_wordcount_it(wordcount.run, machine_type='t2a-standard-1')
-
def _run_wordcount_it(self, run_wordcount, **opts):
test_pipeline = TestPipeline(is_integration_test=True)
extra_opts = {}
+ if (test_pipeline.get_option('machine_type') == 't2a-standard-1' and
+ 'prebuild_sdk_container_engine' in opts):
+ pytest.skip('prebuild_sdk_container_engine not supported on ARM')
Review Comment:
You could mention https://github.com/apache/beam/issues/28340 in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1736044109
LGTM. Looks like the only test we are adding atm is sibling_sdk_worker IT test (still a wordcount test; we can remove that test next week). Running all tests could help with future ValCont tests but wouldn't significantly increase coverage now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28627: Run arm suite against all validates_container tests
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28627:
URL: https://github.com/apache/beam/pull/28627#issuecomment-1733901239
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org