[GitHub] [hive] pvargacl commented on a change in pull request #1474: Revert "HIVE-23725: ValidTxnManager snapshot outdating causing partia…

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1474:
URL: https://github.com/apache/hive/pull/1474#discussion_r484388472



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -2324,142 +2315,6 @@ private void testConcurrentMergeInsertNoDuplicates(String query, boolean sharedW
     List res = new ArrayList();
     driver.getFetchTask().fetch(res);
     Assert.assertEquals("Duplicate records found", 4, res.size());
-    dropTable(new String[]{"target", "source"});
-  }
-
-  /**
-   * ValidTxnManager.isValidTxnListState can invalidate a snapshot if a relevant write transaction was committed
-   * between a query compilation and lock acquisition. When this happens we have to recompile the given query,
-   * otherwise we can miss reading partitions created between. The following three cases test these scenarios.
-   * @throws Exception ex
-   */
-  @Test
-  public void testMergeInsertDynamicPartitioningSequential() throws Exception {

Review comment:
       These tests should be added back in your next change, when we recompile without the reexec driver, to verify the dyn partitioning use-cases




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org