[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467748#comment-16467748 ] 

ASF GitHub Bot commented on METRON-1549:
----------------------------------------

GitHub user mmiklavc opened a pull request:

    https://github.com/apache/metron/pull/1009

    1549: Add empty object test to WriterBoltIntegrationTest implementation

    ## Contributor Comments
    
    https://issues.apache.org/jira/browse/METRON-1549
    
    Adding a new integration test case to the writer bolt integration test to verify an edge case with how our parserbolt, parsers, and writers handle empty objects returned from custom parsers.
    
    ## Pull Request Checklist
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    (pending travis)
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    
    
    ### For documentation related changes:
    n/a


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/metron parser-bolt-ack-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1009
    
----
commit 9fc9e50bfec698a62e83619ca9bbf120b8c5b956
Author: Michael Miklavcic <mi...@...>
Date:   2018-05-08T17:39:59Z

    Add test for parsers returning empty JSONObjects as an element of their returned list

----


> Add empty object test to WriterBoltIntegrationTest implementation
> -----------------------------------------------------------------
>
>                 Key: METRON-1549
>                 URL: https://issues.apache.org/jira/browse/METRON-1549
>             Project: Metron
>          Issue Type: Test
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>
> Verify expected output when empty objects returned by custom parsers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)