You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/05/05 11:22:28 UTC
[PR] Run parallel tess for ARM platform [airflow]
potiuk opened a new pull request, #50198:
URL: https://github.com/apache/airflow/pull/50198
Since we have `ubintu22.04-arm` public runners available, we should be able to run a set of parallel tests for ARM - this would make our ARM images move out of experimental phase.
We are not running "all" tests - only those that make sense to run on ARM for "production" quality.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run parallel tests for ARM platform [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #50198:
URL: https://github.com/apache/airflow/pull/50198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run parallel tests for ARM platform [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #50198:
URL: https://github.com/apache/airflow/pull/50198#discussion_r2074108843
##########
.github/workflows/ci-amd.yml:
##########
@@ -825,10 +843,51 @@ jobs:
# yamllint disable rule:line-length
payload: |
channel: "internal-airflow-ci-cd"
- text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
+ text: "🚨🕒 Scheduled CI Failure Alert (AMD) 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
blocks:
- type: "section"
text:
type: "mrkdwn"
- text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
+ text: "🚨🕒 Scheduled CI Failure Alert (AMD) 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
# yamllint enable rule:line-length
+
+ summarize-warnings:
+ timeout-minutes: 15
+ name: "Summarize warnings"
+ runs-on: ${{ fromJSON(needs.build-info.outputs.amd-runners) }}
+ if: needs.build-info.outputs.run-tests == 'true'
+ steps:
+ - name: "Cleanup repo"
+ shell: bash
+ run: docker run -v "${GITHUB_WORKSPACE}:/workspace" -u 0:0 bash -c "rm -rf /workspace/*"
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+ uses: actions/checkout@v4
+ with:
+ persist-credentials: false
+ - name: "Cleanup docker"
+ run: ./scripts/ci/cleanup_docker.sh
+ - name: "Free up disk space"
+ shell: bash
+ run: ./scripts/tools/free_up_disk_space.sh
+ - name: "Download all test warning artifacts from the current build"
+ uses: actions/download-artifact@v4
+ with:
+ path: ./artifacts
+ pattern: test-warnings-*
+ - name: "Setup python"
+ uses: actions/setup-python@v5
+ with:
+ python-version: ${{ inputs.default-python-version }}
+ - name: "Summarize all warnings"
+ run: |
+ ./scripts/ci/testing/summarize_captured_warnings.py ./artifacts \
+ --pattern "**/warnings-*.txt" \
+ --output ./files
+ - name: "Upload artifact for summarized warnings"
+ uses: actions/upload-artifact@v4
+ with:
+ name: test-summarized-warnings
Review Comment:
```suggestion
name: test-summarized-amd-runner-warnings
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run parallel tests for ARM platform [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #50198:
URL: https://github.com/apache/airflow/pull/50198#discussion_r2074103495
##########
.github/workflows/ci-amd.yml:
##########
@@ -470,7 +478,8 @@ jobs:
contents: read
packages: read
with:
- amd-runners: ${{ needs.build-info.outputs.amd-runners }}
+ runners: ${{ needs.build-info.outputs.runners }}
Review Comment:
```suggestion
runners: ${{ needs.build-info.outputs.amd-runners }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run parallel tests for ARM platform [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #50198:
URL: https://github.com/apache/airflow/pull/50198#discussion_r2074102787
##########
.github/workflows/ci-amd.yml:
##########
@@ -359,7 +363,8 @@ jobs:
contents: read
packages: read
with:
- amd-runners: ${{ needs.build-info.outputs.amd-runners }}
+ runners: ${{ needs.build-info.outputs.runners }}
Review Comment:
```suggestion
runners: ${{ needs.build-info.outputs.amd-runners }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run parallel tests for ARM platform [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #50198:
URL: https://github.com/apache/airflow/pull/50198#issuecomment-2853635704
For now I disabled the "pull request" trigger:
The tests will run:
* canary runs on schedule (shifted by 3 hours from the regular AMD schedule)
* when we merge to any of the v* branches
* when we trigger it manually with `workflow-dispatch`
This will not have impact on regular PRs and we will have time to observe stability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org