[GitHub] [maven-resolver] michael-o edited a comment on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

[GitBox <gi...@apache.org>]

michael-o edited a comment on pull request #65:
URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661291308


   > Syncontext must be global if you want an useful global lock but it uses an int so it is not thread safe. If not global it does not impl its original goal so in all cases it looks incomplete.
   
   I absolutely do not agree with that. If SyncContext would be global one would not need the factory at all. It would be ridiculous. Reread the API requirements on SyncContext instances. The global lock resides in the singleton factory and it is used throughout. The int *is* threadsafe because it lives in the SyncContext instance only, it is not shared. Please provide a PR which depicts your understanding of the truth.
   
   > Do you have particular links? Also the point to enable to lock per artifact is not bound to these impl issues, the impl still proves there is no mem issue to do it
   
   https://github.com/takari/takari-local-repository/issues/12 as well as the MRESOLVER-123, -25 and -114. I requested to use the Takari extension in the spirit that it works. It turned out not to. Read through the discussions, take the time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org